Remove optional revert error return types from web3-eth TS definitions #3504
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR removes error return types which cause tsc compilation errors when used in a statement that declares a type for the LHS of some web3-eth methods. The error isn't really a return value, it's the type of the error object passed to the
catch
clause.For example:
...currently throws
(Looked around at a few TS projects to see how (or if) defining custom error types for Promise rejections is done but don't see a lot of examples. )
Fixes #3496
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.CHANGELOG.md
file in the root folder.